Commit f45ede40 authored by yanglbme's avatar yanglbme

chore: change to final fields

parent 05824f25
...@@ -15,8 +15,8 @@ import java.util.concurrent.ThreadLocalRandom; ...@@ -15,8 +15,8 @@ import java.util.concurrent.ThreadLocalRandom;
* @since 2021/07/29 16:11 * @since 2021/07/29 16:11
*/ */
public class IMClient { public class IMClient {
private static ConcurrentHashMap<String, IMClient> imClient = new ConcurrentHashMap<>(); private static final ConcurrentHashMap<String, IMClient> IM_CLIENT = new ConcurrentHashMap<>();
private static String FORMAT_URL = "https://console.tim.qq.com/%s/%s/%s?sdkappid=%d&identifier=%s&usersig=%s&random=%d&contenttype=json"; private static final String FORMAT_URL = "https://console.tim.qq.com/%s/%s/%s?sdkappid=%d&identifier=%s&usersig=%s&random=%d&contenttype=json";
/** /**
* core methods * core methods
*/ */
...@@ -27,25 +27,25 @@ public class IMClient { ...@@ -27,25 +27,25 @@ public class IMClient {
/** /**
* init property * init property
*/ */
private String version = "v4"; private final String version = "v4";
private Long sdkAppId; private final Long sdkAppId;
private String userId; private final String userId;
private String userSig; private final String userSig;
public static IMClient getInstance(Long sdkAppId, String userId, String key, Long expire) { public static IMClient getInstance(Long sdkAppId, String userId, String key, Long expire) {
String identify = sdkAppId + "_" + userId; String identify = sdkAppId + "_" + userId;
if (imClient.get(identify) == null) { if (IM_CLIENT.get(identify) == null) {
imClient.putIfAbsent(identify, new IMClient(sdkAppId, userId, key, expire)); IM_CLIENT.putIfAbsent(identify, new IMClient(sdkAppId, userId, key, expire));
} }
return imClient.get(identify); return IM_CLIENT.get(identify);
} }
public static IMClient getInstance(Long sdkAppId, String userId, String key) { public static IMClient getInstance(Long sdkAppId, String userId, String key) {
String identify = sdkAppId + "_" + userId; String identify = sdkAppId + "_" + userId;
if (imClient.get(identify) == null) { if (IM_CLIENT.get(identify) == null) {
imClient.putIfAbsent(identify, new IMClient(sdkAppId, userId, key, 24 * 60 * 60L)); IM_CLIENT.putIfAbsent(identify, new IMClient(sdkAppId, userId, key, 24 * 60 * 60L));
} }
return imClient.get(identify); return IM_CLIENT.get(identify);
} }
public IMClient(Long sdkAppId, String userId, String key, Long expire) { public IMClient(Long sdkAppId, String userId, String key, Long expire) {
......
...@@ -22,7 +22,7 @@ public class Account { ...@@ -22,7 +22,7 @@ public class Account {
private static final String KICK = "kick"; private static final String KICK = "kick";
private static final String QUERY_STATE = "querystate"; private static final String QUERY_STATE = "querystate";
private IMClient imClient; private final IMClient imClient;
public Account(IMClient imClient) { public Account(IMClient imClient) {
this.imClient = imClient; this.imClient = imClient;
......
...@@ -19,7 +19,7 @@ public class Message { ...@@ -19,7 +19,7 @@ public class Message {
private static final String SEND_MSG_COMMAND = "sendmsg"; private static final String SEND_MSG_COMMAND = "sendmsg";
private static final String IMPORT_MSG_COMMAND = "importmsg"; private static final String IMPORT_MSG_COMMAND = "importmsg";
private IMClient imClient; private final IMClient imClient;
public SendMsgResult sendMsg(SendMsgRequest sendMsgRequest) throws IOException { public SendMsgResult sendMsg(SendMsgRequest sendMsgRequest) throws IOException {
String url = imClient.getUrl(SERVICE_NAME, SEND_MSG_COMMAND); String url = imClient.getUrl(SERVICE_NAME, SEND_MSG_COMMAND);
......
...@@ -16,7 +16,7 @@ public class Profile { ...@@ -16,7 +16,7 @@ public class Profile {
private static final String SERVICE_NAME = "profile"; private static final String SERVICE_NAME = "profile";
private static final String PORTRAIT_SET_COMMAND = "portrait_set"; private static final String PORTRAIT_SET_COMMAND = "portrait_set";
private IMClient imClient; private final IMClient imClient;
public PortraitSetResult portraitSet(PortraitSetRequest portraitSetRequest) throws IOException { public PortraitSetResult portraitSet(PortraitSetRequest portraitSetRequest) throws IOException {
String url = imClient.getUrl(SERVICE_NAME, PORTRAIT_SET_COMMAND); String url = imClient.getUrl(SERVICE_NAME, PORTRAIT_SET_COMMAND);
......
...@@ -16,7 +16,7 @@ public class SNS { ...@@ -16,7 +16,7 @@ public class SNS {
private static final String SERVICE_NAME = "sns"; private static final String SERVICE_NAME = "sns";
private static final String FRIEND_IMPORT_COMMAND = "friend_import"; private static final String FRIEND_IMPORT_COMMAND = "friend_import";
private IMClient imClient; private final IMClient imClient;
public FriendImportResult friendImport(FriendImportRequest friendImportRequest) throws IOException { public FriendImportResult friendImport(FriendImportRequest friendImportRequest) throws IOException {
String url = imClient.getUrl(SERVICE_NAME, FRIEND_IMPORT_COMMAND); String url = imClient.getUrl(SERVICE_NAME, FRIEND_IMPORT_COMMAND);
......
...@@ -15,8 +15,8 @@ import java.util.Properties; ...@@ -15,8 +15,8 @@ import java.util.Properties;
* @since 2021/7/30 16:17 * @since 2021/7/30 16:17
*/ */
public class AccountTest { public class AccountTest {
private static Properties properties = new Properties(); private static final Properties properties = new Properties();
private static IMClient client; private static final IMClient client;
static { static {
InputStream resourceAsStream = AccountTest.class.getClassLoader().getResourceAsStream("app.properties"); InputStream resourceAsStream = AccountTest.class.getClassLoader().getResourceAsStream("app.properties");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment